This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[NC-2180] Wait for a peer with an estimated chain height before selecting a pivot block #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot block and handle peers that disconnect between the wait and pivot block selection.
mbaxter
approved these changes
Feb 5, 2019
| parentHeader.getHash())); | ||
| } | ||
| return result; | ||
| } catch (Throwable t) { |
There was a problem hiding this comment.
Curious - why do you need this try / catch?
There was a problem hiding this comment.
Oh we shouldn't need it and I've removed it again. That said, somewhere we're swallowing exceptions silently so will need to track that down and fix separately.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
When selecting a pivot block we need to ensure the estimated chain height for at least one peer is actually available. This may fail because the chain header block hasn't yet been retrieved from the peer or because the peer connected, causing the wait for peer task to complete, but then disconnected before we could select a pivot block. This change updates
FastSyncActions.selectPivotBlockto ignore peers without a chain height estimate and retry if a peer isn't available.