This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[NC-1968] Permissioning whitelist persistence. #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-terry
changed the title
.../tech/pegasys/pantheon/tests/acceptance/dsl/condition/perm/WhiteListContainsKeyAndValue.java
Outdated
Show resolved
Hide resolved
...a/tech/pegasys/pantheon/tests/acceptance/permissioning/WhitelistPersistorAcceptanceTest.java
Outdated
Show resolved
Hide resolved
...sys/pantheon/ethereum/jsonrpc/internal/methods/permissioning/PermAddAccountsToWhitelist.java
Show resolved
Hide resolved
.../src/main/java/tech/pegasys/pantheon/ethereum/p2p/permissioning/NodeWhitelistController.java
Show resolved
Hide resolved
...issioning/src/main/java/tech/pegasys/pantheon/ethereum/permissioning/WhitelistPersistor.java
Outdated
Show resolved
Hide resolved
macfarla
reviewed
Feb 5, 2019
| .collect(Collectors.toList()); | ||
| } | ||
|
|
||
| Files.write( |
There was a problem hiding this comment.
could it happen that the remove file.write succeeds but the add fails?
There was a problem hiding this comment.
Updating the PR with checks for this case. 👍
There was a problem hiding this comment.
PR has been updated to include config file state verification, which verifies the before and after state and will (at least attempt to) revert to the before state if the operation fails.
mark-terry
force-pushed
the
NC-1968-update
branch
from
bf89833
to
ba87c6c
Compare
lucassaldanha
approved these changes
Feb 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Implemented functionality to persist permissioning whitelists across restarts.
Fixed Issue(s)
Fixes #NC-1968