This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Handle validation failures when fast importing blocks #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaxter
approved these changes
Feb 1, 2019
| } | ||
|
|
||
| @Test | ||
| public void shouldReturnExceptionallyCompletedFutureWhenBlockImportFails() { |
There was a problem hiding this comment.
(optional) Might also be good to have a test that imports a sequence of blocks and fails early in that sequence. Then we can check that fastImportBlock doesn't get called for the blocks after the failure.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
When a fast import block fails validation we need to halt the import and retry. Previously we incorrectly ignored the failure and continued trying to import future blocks (which would also fail validation because the parent doesn't exist).