This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Ibft to uniquely ID messages by their hash #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jframe
reviewed
Jan 31, 2019
jframe
reviewed
Jan 31, 2019
|
|
||
| @Test | ||
| public void anonymousMessageDataClassesContainingTheSameDataAreConsideredIdentical() { | ||
| final MessageData arbitraryMessage_1 = |
There was a problem hiding this comment.
a function that creates the arbitrary message using the anonymous class would make this test more readable
jframe
approved these changes
Feb 1, 2019
CjHare
approved these changes
Feb 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ibft was re-gossiping previously sent messages due to using 'hashcode' which, for anonymous MessageData objects never matched.
This has been updated to use Hash instead.