This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[NC-2110] Removed CLI options for --nodes-whitelist and --accounts-wh… #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itelist and associated items.
NicolasMassart
approved these changes
Jan 29, 2019
vinistevam
pushed a commit
to vinistevam/pantheon
that referenced
this pull request
Jan 29, 2019
…itelist and associated items. (PegaSysEng#694)
macfarla
reviewed
Jan 29, 2019
| params.add("--accounts-whitelist"); | ||
| params.add(String.join(",", permissioningConfiguration.getAccountWhitelist().toString())); | ||
| } | ||
|
|
There was a problem hiding this comment.
Now that we have --permissions-nodes-enabled and --permissions-accounts-enabled, we need to set those here instead
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…itelist and associated items.
PR description
The --nodes-whitelist and --accounts-whitelist CLI options have been removed in favour of a separate permissioning configuration file.
Fixed Issue(s)
#NC-2110