This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
NC-2120 --discovery-enabled option refactoring #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now able to have --discovery-enabled option with true as default and --discovery-enabled=true or --discovery-enabled=false on CLI and discovery-enabled=true or discovery-enabled=false in YAML config file.
NicolasMassart
added
documentation
| @@ -36,7 +36,9 @@ Trailing peers cannot be used to get new blocks and are more likely to be reques | |||
|
|
|||
| ## No Discovery | |||
|
|
|||
| The [`--no-discovery`](../Reference/Pantheon-CLI-Syntax.md#no-discovery) command line option disables P2P peer discovery. Only use this option if you are running a test node or a test network with fixed nodes. | |||
| The [`--rpc-ws-enabled`](../Reference/Pantheon-CLI-Syntax.md#rpc-ws-enabled) command line option | |||
There was a problem hiding this comment.
Should rpc-ws-enabled be discover-enabled?
| The [`--no-discovery`](../Reference/Pantheon-CLI-Syntax.md#no-discovery) command line option disables P2P peer discovery. Only use this option if you are running a test node or a test network with fixed nodes. | ||
| The [`--rpc-ws-enabled`](../Reference/Pantheon-CLI-Syntax.md#rpc-ws-enabled) command line option | ||
| enables P2P peer discovery. | ||
| Only set this option to `false` if you are running a test node or a test network with fixed nodes. |
There was a problem hiding this comment.
'Only set this option to' -> 'Set to' -> uses less words and still has the same meaning
|
|
||
| ```bash tab="Syntax" | ||
| --no-discovery | ||
| --discovery-enabled=false |
There was a problem hiding this comment.
For p2p-enabled I specified the syntax as --p2p-enabled=<true|false> because you can specify true. I think either way is fine but we should make them the same so just let me know what you end up doing.
rain-on
pushed a commit
to rain-on/pantheon
that referenced
this pull request
Jan 29, 2019
fixes NC-2120 --discovery-enabled option refactoring now able to have --discovery-enabled option with true as default and --discovery-enabled=true or --discovery-enabled=false on CLI and discovery-enabled=true or discovery-enabled=false in YAML config file. updates doc
vinistevam
pushed a commit
to vinistevam/pantheon
that referenced
this pull request
Jan 29, 2019
fixes NC-2120 --discovery-enabled option refactoring now able to have --discovery-enabled option with true as default and --discovery-enabled=true or --discovery-enabled=false on CLI and discovery-enabled=true or discovery-enabled=false in YAML config file. updates doc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
now able to have --discovery-enabled option with true as default
and --discovery-enabled=true or --discovery-enabled=false on CLI
and discovery-enabled=true or discovery-enabled=false in YAML config file.
Fixed Issue(s)
fixes NC-2120