Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

[PRIV] Remove OrionConfiguration #644

Merged
merged 2 commits into from
Jan 23, 2019
Merged

[PRIV] Remove OrionConfiguration #644

merged 2 commits into from
Jan 23, 2019

Conversation

Puneetha17
Copy link
Contributor

PR description

  • Remove OrionConfiguration to avoid circular dependency.
  • Rename SendContent and ReceiveContent to SendRequest and ReceiveRequest, respectively, to make it more coherent.

macfarla
macfarla approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: would be nice to have the refactor/rename separate from the Orion/dependency change - one PR = one change

@CjHare CjHare merged commit c8f1748 into PegaSysEng:master Jan 23, 2019
@Puneetha17 Puneetha17 deleted the refactor branch January 24, 2019 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@macfarla macfarla macfarla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Puneetha17 @macfarla @CjHare