This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
NC-2104 Clique and iBFT should not be defined by default in RPC APIs #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As toString() is used to display default values in CLI description and this is not used anywhere else for RpcApi objects, it may have benn used for debug long ago, but now we can use the simple string value as return from toString. Then we are able to use the DEFAULT_JSON_RPC_APIS constant as default value directly instead of hard coded defaults string in option that was probably used because previous toString was not outputting correct representation. It may be interesting to comment when some does this sort of hack.
…values As toString() is used to display default values in CLI description and this is not used anywhere else for RpcApi objects, it may have benn used for debug long ago, but now we can use the simple string value as return from toString. Then we are able to use the DEFAULT_JSON_RPC_APIS constant as default value directly instead of hard coded defaults string in option that was probably used because previous toString was not outputting correct representation. It may be interesting to comment when some does this sort of hack.
NicolasMassart
requested review from
ajsutton,
Errorific,
rain-on and
MadelineMurray
ajsutton
approved these changes
Jan 22, 2019
ethereum/jsonrpc/src/main/java/tech/pegasys/pantheon/ethereum/jsonrpc/RpcApi.java
Show resolved
Hide resolved
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Clique and iBFT should not be defined by default in HTTP and Websocket RPC APIs options.
This PR removes the default values for both Clique and iBFT and removes the hard coded string used as default value for description and replaces it with a constant default that's can be changed in one place.
Fixed Issue(s)
fixes NC-2104