This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
NC 2004 no discovery still talk to bootnodes #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…no-discovery-still-talk-to-bootnodes
…no-discovery-still-talk-to-bootnodes
…no-discovery-still-talk-to-bootnodes
…no-discovery-still-talk-to-bootnodes
mark-terry
approved these changes
Jan 23, 2019
| @@ -333,6 +336,10 @@ public boolean isDevMode() { | |||
| return devMode; | |||
| } | |||
|
|
|||
| public boolean isDiscovery() { | |||
There was a problem hiding this comment.
isDiscovery() or discoveryEnabled() ?
| @@ -40,7 +41,8 @@ | |||
| final PermissioningConfiguration permissioningConfiguration, | |||
| final boolean devMode, | |||
| final GenesisConfigProvider genesisConfigProvider, | |||
| final Boolean p2pEnabled) { | |||
| final Boolean p2pEnabled, | |||
| final boolean discovery) { | |||
There was a problem hiding this comment.
Nitpick: Field that's being set is Boolean, this is boolean. Should probably be the former.
| @@ -80,6 +83,10 @@ public boolean isDevMode() { | |||
| return devMode; | |||
| } | |||
|
|
|||
| public Boolean isDiscovery() { | |||
There was a problem hiding this comment.
See previous isDiscovery() suggestion.
…no-discovery-still-talk-to-bootnodes
….com:macfarla/pantheon into nc-2004-no-discovery-still-talk-to-bootnodes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Added ability in acceptance tests to set up a node with --no-discovery
Fixed Issue(s)
Related to NC-2004