Refactoring for more readable IBFT IT

[CjHare]

A key goal of maintainable tests come from readability, any time the mental effort needed to understand the intent of the test, the better the chance of proper maintenance.

By removing the getter to the list of non proposing validators, I believe it creates a slightly nicer to read integration test.

this:

 roles
	        .getNonProposingPeers()
	        .forEach(
	            p -> {
	              p.injectPrepare(roundId, currentHeightBlock.getHash());
	              p.injectCommit(roundId, currentHeightBlock.getHash());
	            });

changes into:

	    roles.nonProposingPeersPrepare(roundId, currentHeightBlock.getHash());
	    roles.nonProposingPeerCommit(roundId, currentHeightBlock.getHash());

[rain-on]

The changes in the test are nice ... but not confident a thing called "Roles" should be generating msgs for the group ...

Maybe a rename needed? Or maybe a wrapping class?

GENERALLY - it'd be really nice if we could seed both the "assertMessagesSentToPeers" and a "Message Sender" with the peers, so we don't need to call them out explicitly ...

[CjHare]

Ah yes, the fun of good naming!

Maybe a rename needed? Or maybe a wrapping class?

Probably a rename, as thnking about it, RoundSpecificNodeRoles is currently just the network of ValidatorPeers.
RoundSpecificValidatorPeers``, RoundSpecificNetworkandRoundSpecificPeers` sound like good candidates, any others?

"assertMessagesSentToPeers" and a "Message Sender" with the peers

This is a great idea, keeping both those functions in the same is grouping that aspect of responsibility together.

[rain-on]

Definitely better than previous.