Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Ibft Int Test - change TestContextFactory to a builder #611

Merged
merged 3 commits into from
Jan 21, 2019

Conversation

rain-on
Copy link
Contributor

@rain-on rain-on commented Jan 21, 2019

This allows individual items of the test framework to be replaced
during the test construction (i.e. eventqueue, clock, validator count).

@rain-on rain-on requested review from jframe and CjHare January 21, 2019 01:31
Copy link
Contributor

@CjHare CjHare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appropriate use of the builder pattern 👍

tmohay added 2 commits January 21, 2019 17:07
This allows individual items of the test framework to be replaced
during the test construction (i.e. eventqueue, clock, validator count).
@rain-on rain-on merged commit 7861600 into PegaSysEng:master Jan 21, 2019
@rain-on rain-on deleted the int_test_bad_peer branch January 24, 2019 10:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants