Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Discard prior round change msgs #610

Merged
merged 4 commits into from
Jan 22, 2019
Merged

Conversation

rain-on
Copy link
Contributor

@rain-on rain-on commented Jan 20, 2019

Ibft will no longer buffer round change messages for prior rounds.
While the messages buffered where discarded on round change, they
should not be buffered.

Ibft will no longer buffer round change messages for prior rounds.
While the messages buffered where discarded on round change, they
should not be buffered.
@rain-on rain-on requested a review from jframe January 20, 2019 21:27
@rain-on rain-on requested a review from CjHare January 21, 2019 22:14
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Make sense to avoid appending the round change if don't need to.

@rain-on rain-on merged commit 9c595ee into PegaSysEng:master Jan 22, 2019
@rain-on rain-on deleted the roundChange branch January 24, 2019 10:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants