[NC-1344] Add GetReceiptsFromPeerTask #598
Conversation
| .values() | ||
| .stream() | ||
| .map(headers -> headers.get(0).getHash()) | ||
| .collect(toList()); |
There was a problem hiding this comment.
We probably want to filter out requests for empty receipt sets. Fine to follow-up with that optimization if you want to go ahead and merge this though.
There was a problem hiding this comment.
I thought about that but if everything in the list winds up being an empty receipt we wouldn't send a request at all and then we don't have a ResponseStream to return and everything gets weird. So I think it's actually better to handle that case back in the calling code - the downside being that it doesn't automatically get re-used if the task winds up called from a second place.
There was a problem hiding this comment.
hmm - wonder if we could have this return an Optional<ResponseStream> or something? In any case, I say we make a ticket to look into it and just merge this as-is for now.
There was a problem hiding this comment.
Yeah that's sensible - then just need to have a way for the task to know it should insert the empty result, which probably boils down to just having a flag set or a condition in the process results section.
There was a problem hiding this comment.
I've added NC-2148 as a subtask so I don't forget this as I work through the actual downloading.
PR description
Adds a GetReceiptsFromPeerTask to support getting transaction receipts from a peer. Receipts are actually requested based on the block hash, not the receipt root, but then we have to match the returned receipts back up to the headers using the receipt root. The task deduplicates headers with the same receipts root to minimise data transferred.
The task returns a map of
BlockHeadertoList<TransactionReceipt>. It could have just used the block hash as the key but that could easily be confused for the receipt root which is also of typeHash.Fixed Issue(s)
NC-1344