This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Fix deprecation warnings #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t seem to be a viable alternative available.
ajsutton
commented
Jan 17, 2019
| @@ -156,7 +155,7 @@ private void validateConfig(final JsonRpcConfiguration config) { | |||
| } | |||
| httpServer = null; | |||
| final Throwable cause = res.cause(); | |||
| if (cause instanceof BindException || cause instanceof SocketException) { | |||
| if (cause instanceof SocketException) { | |||
There was a problem hiding this comment.
For the record, BindException is a subclass of SocketException.
shemnon
approved these changes
Jan 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Vertx deprecated a few methods which caused some new warnings when building. Two of them have simple replacements (you can now use the router directly instead of needing a method reference) and the other had to be suppressed as the method is being changed in vertx 4 but I don't see a suitable replacement while still on vertx 3.
And while in the files, fix the other warnings IntellIJ flagged (mostly adding final).