This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
IBFT Integration Tests - Future Height #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds tests to ensure the IBFT capability handles the chain updating "under" the state machine.
CjHare
reviewed
Jan 17, 2019
|
|
||
| private final int NETWORK_SIZE = 5; | ||
|
|
||
| // Local node is not the first proposer for the current round. |
There was a problem hiding this comment.
Is this message correct? where or what is local node ...I don't see a field with that name
There was a problem hiding this comment.
Not sure how to handle this - but all integration tests are exercising the ibftController embedded in the TestContext - which I treat/consider the localNode.
Would love better nomenclature.
jframe
reviewed
Jan 18, 2019
...sus/ibft/src/main/java/tech/pegasys/pantheon/consensus/ibft/statemachine/IbftController.java
Show resolved
Hide resolved
...t/src/integration-test/java/tech/pegasys/pantheon/consensus/ibft/tests/FutureHeightTest.java
Show resolved
Hide resolved
jframe
approved these changes
Jan 21, 2019
CjHare
reviewed
Jan 21, 2019
| @@ -37,7 +37,7 @@ | |||
| public class TestHelpers { | |||
|
|
|||
| public static SignedData<CommitPayload> createSignedCommentPayload( | |||
| final Block block, final KeyPair signingKeyPair, final ConsensusRoundIdentifier roundId) { | |||
| final ConsensusRoundIdentifier roundId, final Block block, final KeyPair signingKeyPair) { | |||
There was a problem hiding this comment.
I like the consistency with other methods 👍
CjHare
approved these changes
Jan 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests to ensure the IBFT capability handles the chain updating
"under" the state machine.