This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Split Block Validation from Importing #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ibft is required to validate a block upon reception, but not import it until a later time. As such, IBFT will require validation and importing to be separated. The validator has been exposed as part of the ProtocolSpecification.
ajsutton
approved these changes
Jan 16, 2019
|
|
||
| public interface BlockValidator<C> { | ||
|
|
||
| class BlockValidationOutputs { |
There was a problem hiding this comment.
As mentioned on #565 before it got chopped up, this is maybe more BlockProcessingOutputs?
| if (!result.isSuccessful()) { | ||
| return false; | ||
| } | ||
| outputs.ifPresent(o -> persistState(o, block, context)); |
There was a problem hiding this comment.
It would be great to avoid using single letter variable names. Always takes me ages to work out what the heck o actually is.
| BlockHeaderValidator<T> blockHeaderValidator, | ||
| BlockBodyValidator<T> blockBodyValidator, | ||
| BlockProcessor blockProcessor); | ||
| } | ||
|
|
||
| public interface BlockImporterBuilder<T> { | ||
| BlockImporter<T> apply(BlockValidator<T> blockValidator); |
There was a problem hiding this comment.
nit: How come all the existing interfaces got an extra blank line added and the new one didn't? (I like the no blank line version not that it really matters)
There was a problem hiding this comment.
(no idea) Attempted to maintain consistency with existing code (i.e no new lines).
iikirilov
pushed a commit
to vinistevam/pantheon
that referenced
this pull request
Jan 24, 2019
Ibft is required to validate a block upon reception, but not import it until a later time. As such, IBFT will require validation and importing to be separated. The validator has been exposed as part of the ProtocolSpecification.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ibft is required to validate a block upon reception, but not import
it until a later time.
As such, IBFT will require validation and importing to be separated.
The validator has been exposed as part of the ProtocolSpecification.