Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Adding the CLI Style Guide #530

Merged
merged 9 commits into from
Jan 9, 2019

Conversation

jakehaugen
Copy link
Contributor

PR description

Added in the CLI Style Guide (top level), new "images" folder and image files in /docs, updated README to link to the CLI Style Guide

Fixed Issue(s)

@CLAassistant
Copy link

CLAassistant commented Jan 8, 2019

CLA assistant check
All committers have signed the CLA.

@jakehaugen jakehaugen changed the title Cli Style Guide Branch CLI Style Guide Branch Jan 8, 2019
@jakehaugen jakehaugen changed the title CLI Style Guide Branch Adding the CLI Style Guide Jan 8, 2019
Copy link
Contributor

@MadelineMurray MadelineMurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

@@ -0,0 +1,246 @@
# Pantheon CLI Style Guide
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI -> Command Line? Personal preference but would command line be better than CLI in the titles.

Copy link
Contributor Author

@jakehaugen jakehaugen Jan 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone back and forth on this as well. I've updated the title to "Command Line Interface (CLI)". I do think it's more clear after doing some research. In addition to that, it made me realize we were being inconsistent with using a hyphen or not (command-line vs. command line). I've matched what existed in the documentation already and changed them all to "command line" (no hyphen).

CLI-STYLE-GUIDE.md Outdated Show resolved Hide resolved

## General Guidelines

There are four guiding principles for the Pantheon CLI to help us create a good developer experience for both new and expert users: **_(1) be consistent, (2) keep it simple, (3) be proactive and (4) be informative (to people and machines)._**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be clearer to have each numbered point on a separate line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hesitant to do this since they're broken out after this section.

CLI-STYLE-GUIDE.md Outdated Show resolved Hide resolved
CLI-STYLE-GUIDE.md Outdated Show resolved Hide resolved
CLI-STYLE-GUIDE.md Outdated Show resolved Hide resolved
@jakehaugen jakehaugen merged commit 7b8d8fd into PegaSysEng:master Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants