This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Acc whitelist api #487
Merged
Acc whitelist api #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-terry
approved these changes
Jan 7, 2019
| public boolean useWhitelist() { | ||
| return (accountWhitelistController.isPresent() | ||
| && accountWhitelistController.get().isAccountWhiteListSet()); | ||
| return accountWhitelistController.map(c -> !c.contains(account)).orElse(false); |
There was a problem hiding this comment.
Could this be simplified further to a noneMatch or anyMatch?
Errorific
pushed a commit
to Errorific/pantheon
that referenced
this pull request
Jan 8, 2019
* Implemented list/add/remove accounts from whitelist * Including account whitelist methods in the JSON-RPC API * Fixing json rpc response for eth_sendrawTransaction with account not authorized * Refactoring TransactionPool account whitelist logic * Acceptance test for accounts whitelist * Errorprone * Fixed account nonce tracking in ATs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Implemented Accounts whitelist JSON-RPC API (perm_addAccountsToWhitelist, perm_RemoveAccountsFromWhitelist, perm_GetAccountsWhitelist).
Summary:
• Implemented JSON-RPC methods.
• Refactored TransactionPool account whitelist validation to improve readability.
• Fixed JSON-RPC eth_sendRawTransaction response for sender not authorized.
• Implemented Account whitelisting acceptance tests (introducing heaps of DLS changes to accommodate this)