This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Update IbftConfig Fields #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RequestTimeout field in the IbftConfig has been updated to be "RequestTimeoutSeconds".
Errorific
reviewed
Dec 14, 2018
| public int getRequestTimeoutMillis() { | ||
| return ibftConfigRoot.getInteger("requesttimeout", DEFAULT_ROUND_EXPIRY_MILLISECONDS); | ||
| public int getRequestTimeoutSeconds() { | ||
| return ibftConfigRoot.getInteger("requesttimeoutseconds", DEFAULT_ROUND_EXPIRY_MILLISECONDS); |
There was a problem hiding this comment.
still got DEFAULT_ROUND_EXPIRY_MILLISECONDS while we're now talking about seconds
Errorific
reviewed
Dec 14, 2018
| @@ -187,7 +187,7 @@ | |||
|
|
|||
| final IbftStateMachine ibftStateMachine = new IbftStateMachine(blockCreatorFactory); | |||
| final IbftProcessor ibftProcessor = | |||
| new IbftProcessor(ibftEventQueue, ibftConfig.getRequestTimeoutMillis(), ibftStateMachine); | |||
| new IbftProcessor(ibftEventQueue, ibftConfig.getRequestTimeoutSeconds(), ibftStateMachine); | |||
There was a problem hiding this comment.
Far side of this call is still referring to it's parameter as millis
jframe
reviewed
Dec 14, 2018
| @@ -36,7 +36,7 @@ public int getBlockPeriodSeconds() { | |||
| return ibftConfigRoot.getInteger("blockperiodseconds", DEFAULT_BLOCK_PERIOD_SECONDS); | |||
| } | |||
|
|
|||
| public int getRequestTimeoutMillis() { | |||
| return ibftConfigRoot.getInteger("requesttimeout", DEFAULT_ROUND_EXPIRY_MILLISECONDS); | |||
| public int getRequestTimeoutSeconds() { | |||
There was a problem hiding this comment.
I think the name requestTimeout doesn't really indicate what it is for. Some mention of the round in name would be good. Perhaps something like initialRoundTimeoutSeconds
There was a problem hiding this comment.
I agree, but can we worry about this one next, don't want to stray TOO far right now.
added 7 commits
December 14, 2018 16:44
Errorific
approved these changes
Dec 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RequestTimeout field in the IbftConfig has been updated to be
"RequestTimeoutSeconds".