This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Feature/ibft round change manager #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rain-on
reviewed
Dec 11, 2018
...ibft/src/main/java/tech/pegasys/pantheon/consensus/ibft/statemachine/RoundChangeManager.java
Show resolved
Hide resolved
...ibft/src/main/java/tech/pegasys/pantheon/consensus/ibft/statemachine/RoundChangeManager.java
Show resolved
Hide resolved
| } | ||
|
|
||
| private static final Logger LOG = LogManager.getLogger(); | ||
| @VisibleForTesting |
There was a problem hiding this comment.
concerned about "VisibleForTesting" on internal data, both here and above.
There was a problem hiding this comment.
I'm open to suggestions of how to test without it.
...ibft/src/main/java/tech/pegasys/pantheon/consensus/ibft/statemachine/RoundChangeManager.java
Show resolved
Hide resolved
...ibft/src/main/java/tech/pegasys/pantheon/consensus/ibft/statemachine/RoundChangeManager.java
Outdated
Show resolved
Hide resolved
.../src/test/java/tech/pegasys/pantheon/consensus/ibft/statemachine/RoundChangeManagerTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/tech/pegasys/pantheon/consensus/ibft/statemachine/RoundChangeManagerTest.java
Outdated
Show resolved
Hide resolved
|
|
||
| Map<ConsensusRoundIdentifier, MessageValidator> messageValidators = Maps.newHashMap(); | ||
|
|
||
| messageValidators.put( |
There was a problem hiding this comment.
Personally, I think these can be mocked to produce required outputs.
jframe
reviewed
Dec 11, 2018
...ibft/src/main/java/tech/pegasys/pantheon/consensus/ibft/statemachine/RoundChangeManager.java
Show resolved
Hide resolved
...ibft/src/main/java/tech/pegasys/pantheon/consensus/ibft/statemachine/RoundChangeManager.java
Outdated
Show resolved
Hide resolved
.../src/test/java/tech/pegasys/pantheon/consensus/ibft/statemachine/RoundChangeManagerTest.java
Show resolved
Hide resolved
rain-on
reviewed
Dec 13, 2018
...ibft/src/main/java/tech/pegasys/pantheon/consensus/ibft/statemachine/RoundChangeManager.java
Show resolved
Hide resolved
...ibft/src/main/java/tech/pegasys/pantheon/consensus/ibft/statemachine/RoundChangeManager.java
Show resolved
Hide resolved
...ibft/src/main/java/tech/pegasys/pantheon/consensus/ibft/statemachine/RoundChangeManager.java
Outdated
Show resolved
Hide resolved
...ibft/src/main/java/tech/pegasys/pantheon/consensus/ibft/statemachine/RoundChangeManager.java
Outdated
Show resolved
Hide resolved
…bft/statemachine/RoundChangeManager.java Co-Authored-By: Errorific <[email protected]>
…bft/statemachine/RoundChangeManager.java Co-Authored-By: Errorific <[email protected]>
rain-on
approved these changes
Dec 13, 2018
jframe
approved these changes
Dec 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Manager for dealing with IBFT round change messages inside a round