This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Ibft RoundState #392
Merged
Ibft RoundState #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errorific
reviewed
Dec 11, 2018
| } | ||
|
|
||
| public void addCommitSeal(final SignedData<CommitPayload> commitPayload) { | ||
| if (!proposalMessage.isPresent()) { |
There was a problem hiding this comment.
simplify to (!proposalMessage.isPresent() || validator.validateCommmitMessage(commitPayload))
There was a problem hiding this comment.
Less lines of code - but potentially harder read - where do other reviewers fall?
Errorific
reviewed
Dec 11, 2018
| } | ||
|
|
||
| @Test | ||
| public void singleVlidatorIsPreparedWithJustProposal() { |
jframe
reviewed
Dec 11, 2018
| } | ||
|
|
||
| public void addPreparedPeer(final SignedData<PreparePayload> prepareMsg) { | ||
| if (!proposalMessage.isPresent()) { |
There was a problem hiding this comment.
Similar to below comment. This is simpler as (!proposalMessage.isPresent()) || (validator.validatePrepareMessage(prepareMsg))
There was a problem hiding this comment.
The suggested change relies on the || operator precedence, in that the validator will fail the commit message if the proposal is not available.
Would prefer to be explicit rather than implicit.
Appreciate the actual functionality is identical.
added 2 commits
December 11, 2018 12:12
The IBFT RoundState is responsible for determining if sufficient valid messages have been received to deem the node "Prepared" or "Committed".
jframe
approved these changes
Dec 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IBFT RoundState is responsible for determining if sufficient
valid messages have been received to deem the node "Prepared" or
"Committed".