This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Move Block data generator test helper to test support package #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errorific
approved these changes
Dec 11, 2018
shemnon
reviewed
Dec 11, 2018
| @@ -10,26 +10,12 @@ | |||
| * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the | |||
| * specific language governing permissions and limitations under the License. | |||
| */ | |||
| package tech.pegasys.pantheon.ethereum.testutil; | |||
| package tech.pegasys.pantheon.ethereum.core; | |||
There was a problem hiding this comment.
Not this package, we don't want to split a package across separate modules. What is wrong with testutil? Perhaps testsupport if we need it out of testutil. But not core, that should only be for classes in :ethereum:core
There was a problem hiding this comment.
As this stands right now it is a technical barrier to us adopting either Java 9 modules or OSGi (mutually exclusive choices, but we want our options open).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Move BlockDataGenerator test helper to test support package so it can be used in other unit tests for creating blocks.
Fixed Issue(s)