This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
NC-1564: Only subscription owner can unsubscribe #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CjHare
reviewed
Oct 11, 2018
| If the connection doesn't own the subscription, we throw a not found exception to avoid | ||
| exposing information from others (e.g. scanning existing subscription ids) | ||
| */ | ||
| if (connectionSubscriptionsMap.get(connectionId) == null |
There was a problem hiding this comment.
I'll suggest moving this logic into a private method, with appropriate name and deleting the comment.
private boolean isExposeSubscriptionDetailsAttempt
mark-terry
approved these changes
Oct 11, 2018
| } | ||
|
|
||
| /* | ||
| If the connection doesn't own the subscription, we throw a not found exception to avoid |
There was a problem hiding this comment.
Sounds like behaviour that needs to be documented.
There was a problem hiding this comment.
I've sent a message to team Pliny. I think they haven't worked on the Pub/Sub documentation yet.
shemnon
added a commit
to shemnon/pantheon
that referenced
this pull request
Mar 12, 2019
Improve the import log line to include relevant metrics like number of transacitons, ommers, and gas usage. Also, this fixes a bug in that we get task times when metrics are not turned on. Sample line: 2019-03-11 21:03:50.245+00:00 | EthScheduler-Workers-3 | INFO | BlockPropagationManager | Imported PegaSysEng#36 / 20 tx / 0 om / 420,000 (4.0%) gas / (0xecb366469d88d9d75b20721581797c1eb1118557b93db9a460dc0e000b9ec7fe) in 0.143s.
shemnon
added a commit
to shemnon/pantheon
that referenced
this pull request
Mar 12, 2019
Improve the import log line to include relevant metrics like number of transacitons, ommers, and gas usage. Also, this fixes a bug in that we get task times when metrics are not turned on. Sample line: 2019-03-11 21:03:50.245+00:00 | EthScheduler-Workers-3 | INFO | BlockPropagationManager | Imported PegaSysEng#36 / 20 tx / 0 om / 420,000 (4.0%) gas / (0xecb366469d88d9d75b20721581797c1eb1118557b93db9a460dc0e000b9ec7fe) in 0.143s.
shemnon
added a commit
to shemnon/pantheon
that referenced
this pull request
Mar 12, 2019
Improve the import log line to include relevant metrics like number of transacitons, ommers, and gas usage. Also, this fixes a bug in that we get task times when metrics are not turned on. Sample line: 2019-03-11 21:03:50.245+00:00 | EthScheduler-Workers-3 | INFO | BlockPropagationManager | Imported PegaSysEng#36 / 20 tx / 0 om / 420,000 (4.0%) gas / (0xecb366469d88d9d75b20721581797c1eb1118557b93db9a460dc0e000b9ec7fe) in 0.143s.
shemnon
added a commit
that referenced
this pull request
Mar 12, 2019
Improve the import log line to include relevant metrics like number of transactions, ommers, and gas usage. Also, this fixes a bug in that we get task times when metrics are not turned on. Sample line: 2019-03-11 21:03:50.245+00:00 | EthScheduler-Workers-3 | INFO | BlockPropagationManager | Imported #36 / 20 tx / 0 om / 420,000 (4.0%) gas / (0xecb366469d88d9d75b20721581797c1eb1118557b93db9a460dc0e000b9ec7fe) in 0.143s.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the connections that created a subscription can unsubscribe.