This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
New round validation #353
Merged
New round validation #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| new RoundChangeCertificate(Collections.emptyList()), | ||
| proposerMessageFactory.createSignedProposalPayload(roundIdentifier, proposedBlock)); | ||
|
|
||
| assertThat(validator.validateNewRoundMessage(msg)).isFalse(); |
There was a problem hiding this comment.
This test would succeed even if the message is signed by the proposer.
This is because no RoundChange message is included in the NewRound message.
The same applies to other tests below.
rain-on
force-pushed
the
new_round_validation
branch
from
cefa3bb
to
533828a
Compare
Errorific
approved these changes
Dec 7, 2018
jframe
approved these changes
Dec 7, 2018
| return false; | ||
| } | ||
|
|
||
| for (final SignedData<RoundChangePayload> roundChangeMsg : |
There was a problem hiding this comment.
Using stream().allMatch could simplify this
|
|
||
| public class TestHelpers { | ||
|
|
||
| public static ConsensusRoundIdentifier createFrom( |
There was a problem hiding this comment.
From the class name or method it isn't clear what it's doing, perhaps rename method to createRoundIdentifier?
saltiniroberto
approved these changes
Dec 7, 2018
rain-on
force-pushed
the
new_round_validation
branch
from
533828a
to
8fe5f1d
Compare
rain-on
force-pushed
the
new_round_validation
branch
from
8fe5f1d
to
8fa8830
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a class which is able to determine if a received IBFT New Round message is valid.