This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Round change validation #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rain-on
force-pushed
the
round_change_validation
branch
2 times, most recently
from
102e65d
to
48aa056
Compare
Errorific
reviewed
Nov 27, 2018
| msg.getUnsignedMessageData().getPreparedCertificate().get(); | ||
|
|
||
| if (!messageValidator.addPreprepareMessage(certificate.getIbftPrePrepareMessage())) { | ||
| LOG.info("Invalid Round Change message, embedded Preprepare message failed validation."); |
There was a problem hiding this comment.
Remove space in RoundChange like other messages
Errorific
reviewed
Nov 27, 2018
| for (final IbftSignedMessageData<IbftUnsignedPrepareMessageData> prepareMsg : | ||
| certificate.getIbftPrepareMessages()) { | ||
| if (!messageValidator.validatePrepareMessage(prepareMsg)) { | ||
| LOG.info("Invalid RoundChange message, embedded prepare message failed validation."); |
rain-on
force-pushed
the
round_change_validation
branch
2 times, most recently
from
e0d9f38
to
e465d6f
Compare
Errorific
approved these changes
Nov 28, 2018
rain-on
force-pushed
the
round_change_validation
branch
3 times, most recently
from
6bb4358
to
21ff411
Compare
RoundChangeValidator has been added which is responsible for validating the content of a RoundChange message by using the underlying MessageValidator capabilities.
rain-on
force-pushed
the
round_change_validation
branch
from
21ff411
to
0c160b3
Compare
| } | ||
|
|
||
| if (prepareCertRound.getRoundNumber() > currentRound.getRoundNumber()) { | ||
| LOG.info("Invalid RoundChange message, PreprepareCertificate is not for a past round."); |
There was a problem hiding this comment.
The correct check is
pepareCertRound.getRoundNumber() < RounChnageMesage.getRoundChangeIdentifier().getRoundIdentifier()
| } | ||
|
|
||
| @Test | ||
| public void roundChangeWithPreprepareFromAFutureRoundFails() { |
There was a problem hiding this comment.
This test may need to be revisited after addressing my other comments
There was a problem hiding this comment.
Updated to state preprepare must be earlier than roundchange target.
rain-on
force-pushed
the
round_change_validation
branch
from
4681f7d
to
a0dc32b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validates round change messages through the use of the underlying MessageValidator class.