Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Dependencies Version upgrade #303

Merged
merged 4 commits into from
Nov 26, 2018
Merged

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Nov 23, 2018

PR description

Upgrade dependency versions
First, Merge all version information into one place
Next, Upgrade most version to their latest non-test version.
Finally, sort dependencies and normalize code format.

Two dependencies were not upgraded:

  • errorprone - There are new checks that require build or source changes.
  • vertex - The license to eclipse 2.0 which is not in our current approved
    license list. Change is trivial but for tracability it should
    be done alone.

* errorprone - There are new checks that require build or source changes.
* vertex - The license to eclipse 2.0 which is not in our current approved
           license list.  Change is trivial but for tracability it should
           be done alone.

Each of these require non-simple trivial to upgrade, and hence should be done
in their own PR.
@shemnon shemnon changed the title Version upgrade Dependencies Version upgrade Nov 24, 2018
Copy link
Contributor

@CjHare CjHare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ...out of interest, did you apply some IDE formatting for the gradle ordering or do it manually?

@shemnon
Copy link
Contributor Author

shemnon commented Nov 26, 2018

I did the gradle stuff by hand. If I had the time I could write a spotless filter, but we will see if we just keep things sorted ourselves.

The version numbers has a plugin I added, just run 'gradle dependencyUpdates' and it will tell us what we could update. IMHO this would be the first thing to do after pushing out a release so we can 'bake in' new versions of the updates.

@shemnon shemnon merged commit 94d049e into PegaSysEng:master Nov 26, 2018
@shemnon shemnon deleted the build_tweaks branch November 26, 2018 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants