This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Remove unnecessary RlpInput and RlpOutput classes #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * <p>Note that as the buffer is wrapped, any change to the content of that buffer may be | ||
| * reflected in the returned value. | ||
| * | ||
| * @param buffer The buffer to wrap. |
There was a problem hiding this comment.
this is a trivial feedback, but what about "The {@link Buffer} to wrap."
There was a problem hiding this comment.
Fair point, but I think I'll just leave it as-is so that the javadoc across this class is consistent.
shemnon
approved these changes
Nov 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
As part of removing
RlpUtils, I noticed that we have some other unnecessary rlp classes. This PR removesVertxBufferRLPInputandVertxBufferRLPOutput.Our
BytesValuelibrary has utilities for wrapping around various types of bytes values including vertxBuffer's. Instead of using custom rlp classes for vertx buffers, we should just wrap these buffers asBytesValue's and use the correspondingBytesValueRlpInputandBytesValueRlpOutputclasses.Also removed
FileRLPInputas it was unused (and we probably want to treat files as another type ofBytesValueif we did need this functionality).