This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Update Client Version to be ethstats friendly #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add os and java version. Currently in a static class.
Pull the version from the jar manifest.
For SNAPSHOT builds store git hash in implementation version, report this in client version.
Missed the all important v
Missed the all important v
There was a problem hiding this comment.
The changes look good to me. The only thing that I'd like to see is a simple test verifying that the version string adheres to the expected format (foo/vX.Y.Z/foo/foo). Just to avoid, in the future, someone changing it by because they didn't have the context of why we have this specific format.
Test for ethstats valid formatting
ajsutton
approved these changes
Nov 14, 2018
license header
constant field style conformance.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Update value returned by web3_clientVersion to be ethstats friendly
Sample values:
pantheon/v0.9.0-dev-f800a0b1/osx-x86_64/oracle-java-1.8
pantheon/v0.9.0-dev-f800a0b1/osx-x86_64/zulu-java-11
pantheon/v0.9.0/linux-x86_64/openjdk-java-12