This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
NC-1815 Rinkeby import can stall with too many fragments #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move "complete what we just got" semantic into the DownloadHeaderSequenceTask. Previously it was completing everything in the chunk it was assigned.
|
This is the more complete fix for https://github.com/PegaSysEng/pantheon/issues/228 as well right? |
ajsutton
approved these changes
Nov 13, 2018
|
This is the more complete fix to #228, correct. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Move "complete what we just got" semantic into the
DownloadHeaderSequenceTask. Previously it was completing everything
in the chunk it was assigned.
Builds off of more generic tests by mbaxter.
Fixed Issue(s)
NC-1815