This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
fixes #233 Allow nodekey to be specified separately to --datadir #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should the --nodekey param be the actual file instead of a directory that contains "./key"? |
|
You're right. I will check that tomorrow. I did it this way because I was focused in using the datadir as the default value using a Path type, but it's easy to do it the way you say. |
…asMassart/pantheon into feature/233_nodekey_option
|
@ekellstrand change from Path to File done |
|
Can we rename this |
NicolasMassart
added
enhancement
ajsutton
reviewed
Nov 13, 2018
.../src/test/java/tech/pegasys/pantheon/tests/acceptance/dsl/node/ThreadPantheonNodeRunner.java
Outdated
Show resolved
Hide resolved
pantheon/src/test/java/tech/pegasys/pantheon/cli/PantheonCommandTest.java
Outdated
Show resolved
Hide resolved
- Centralised (sic) the key default file into a static method in KeyPairUtils - Changed the file equality test as I forgot the file type is comparable... no comment...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
added a --nodekey option to the CLI to be able to define a separate path for the private key when starting pantheon.
Fixed Issue(s)
fixes #233