Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Implementing eth_chainId (#206) #219

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Implementing eth_chainId (#206) #219

merged 1 commit into from
Oct 31, 2018

Conversation

lucassaldanha
Copy link
Contributor

PR description

  • Adding support for EIP-695
  • Refactoring chainId to be used as an integer
  • Updated net_version to return the number as a String

Fixed Issue(s)

Fixes #206

@lucassaldanha lucassaldanha self-assigned this Oct 31, 2018
@lucassaldanha lucassaldanha added the api Related to public APIs label Oct 31, 2018
ajsutton
ajsutton approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lucassaldanha lucassaldanha merged commit c71944f into PegaSysEng:master Oct 31, 2018
@lucassaldanha lucassaldanha deleted the chain-id branch October 31, 2018 19:46
@lucassaldanha lucassaldanha mentioned this pull request Nov 2, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ajsutton ajsutton ajsutton approved these changes

Assignees

@lucassaldanha lucassaldanha

Labels
api Related to public APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucassaldanha @ajsutton