This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Split parsing of genesis config from creating initial state #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y in multiple places. Fix discrepancy in how CliqueProtocolSchedule and CliquePantheonController loaded the block period configuration.
…ing the top level of a genesis config file.
…fig as optionals instead of providing the default.
…e genesis config file and rename GenesisConfig to GenesisState as it is now just responsible for creating the initial state at genesis.
…tely as the GenesisConfigFile is already provided.
…r instead of the chain ID and use downloader parallelism setting instead of network ID for the number of threads.
shemnon
pushed a commit
to shemnon/pantheon
that referenced
this pull request
Nov 14, 2018
…ng#209) * Make GenesisConfigFile responsible for handling all the content in the genesis config file and rename GenesisConfig to GenesisState as it is now just responsible for creating the initial state at genesis. * In CliqueProtocolController, pass the network ID to EthProtocolManager instead of the chain ID and use downloader parallelism setting instead of network ID for the number of threads.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Split the responsibility for parsing the content of genesis config from the actual creation if the genesis block and initial world state. Builds on #208
GenesisConfigis now two objectsGenesisConfigFileandGenesisState. The former is responsible for parsing the config, the latter for acting on it to create state.GenesisConfigFilealso provides access toGenesisConfigOptionsto access theconfigsection (including consensus settings).EthProtocolManager. The simpler config setup made this more obvious so it has been fixed.