Add benchmark for BlockHashOperation #203
Conversation
…he underlying cost of the calculation.
ajsutton
force-pushed
the
blockhashop-benchmark
branch
from
a8f55a4
to
e17c7d8
Compare
| public class OperationBenchmarkHelper { | ||
|
|
||
| private final Path storageDirectory; | ||
| private final RocksDbKeyValueStorage keyValueStorage; |
There was a problem hiding this comment.
Does this need to be RocksDbKeyValueStorage? Can we use the abstract parent?
There was a problem hiding this comment.
We need access to the close method which is only on RocksDbKeyValueStorage. I think I might follow up with another PR to add close to the KeyValueStorage interface which would improve this kind of thing in a few places, but outside this scope of this change.
|
|
||
| public static OperationBenchmarkHelper create() throws IOException { | ||
| final Path storageDirectory = Files.createTempDirectory("benchmark"); | ||
| final RocksDbKeyValueStorage keyValueStorage = RocksDbKeyValueStorage.create(storageDirectory); |
There was a problem hiding this comment.
Could we use Provider and pass it into create?
There was a problem hiding this comment.
My aim here is to make pull as much of the complexity out of the benchmark classes where it would have to be repeated into this helper class where it can be shared. This also isn't the type of benchmark where you'd test out multiple back-ends because the usage of storage is typically very light (even SSTORE wouldn't affect the key value storage in this scope).
PR description
Adds a micro-benchmark for the BlockHashOperation and a reusable
OperationBenchmarkHelperto make it easier to write benchmarks for other operations.