This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-3126] add an override facility for genesis configs #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaxter
reviewed
Sep 9, 2019
| final String value = configOverrides.get(key); | ||
| return value == null || value.isEmpty() | ||
| ? OptionalLong.empty() | ||
| : OptionalLong.of(Long.valueOf(configOverrides.get(key))); |
There was a problem hiding this comment.
Should we explicitly specify the radix here?
| final String value = configOverrides.get(key); | ||
| return value == null || value.isEmpty() | ||
| ? OptionalInt.empty() | ||
| : OptionalInt.of(Integer.valueOf(configOverrides.get(key))); |
There was a problem hiding this comment.
Should we explicitly specify the radix here?
| final GenesisConfigFile config = GenesisConfigFile.development(); | ||
| final int bigBlock = 999_999_999; | ||
| final String bigBlockString = Integer.toString(bigBlock); | ||
| final Map<String, String> override = new TreeMap<>(String.CASE_INSENSITIVE_ORDER); |
There was a problem hiding this comment.
Can we add some tests that use a case-sensitive Map with various casing strategies for the keys to verify that values are replaced in a case-insensitive way?
mbaxter
approved these changes
Sep 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Add a generalized genesis config override facility for command line use. Only useful for string or integer config values, not object values.
Sample use - enable Istanbul fork on block 99 million
--override-genesis-config=istanbulFork=99000000Overriding a value with an empty string unsets the value
Sample use - disable Istanbul fork by un-setting
istanbulFork:--override-genesis-config=istanbulFork=