This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2928] return null private transaction receipt instead of error #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iikirilov
force-pushed
the
pan-2928-return-null-private-tx-receipt
branch
from
2ae5adb to
2de3fce
Compare
rain-on
reviewed
Aug 27, 2019
...pegasys/pantheon/ethereum/jsonrpc/internal/methods/privacy/eea/EeaGetTransactionReceipt.java
Outdated
Show resolved
Hide resolved
iikirilov
force-pushed
the
pan-2928-return-null-private-tx-receipt
branch
from
abf7dab to
1579426
Compare
rain-on
approved these changes
Aug 27, 2019
|
This PR is blocked by acceptance test problems that have been fixed in #1864 As this PR does not block anything itself it will not be patched |
iikirilov
force-pushed
the
pan-2928-return-null-private-tx-receipt
branch
from
363a25f to
75b237f
Compare
antonydenyer
approved these changes
Sep 3, 2019
| when(privacyParameters.getPrivateTransactionStorage()).thenReturn(privateTransactionStorage); | ||
| when(privateTransactionStorage.getEvents(any(Bytes32.class))).thenReturn(Optional.empty()); | ||
| when(privateTransactionStorage.getOutput(any(Bytes32.class))).thenReturn(Optional.empty()); | ||
| } |
rain-on
reviewed
Sep 4, 2019
...pegasys/pantheon/ethereum/jsonrpc/internal/privacy/methods/eea/EeaGetTransactionReceipt.java
Outdated
Show resolved
Hide resolved
...sys/pantheon/ethereum/jsonrpc/internal/privacy/methods/eea/EeaGetTransactionReceiptTest.java
Outdated
Show resolved
Hide resolved
iikirilov
commented
Sep 4, 2019
| @@ -104,7 +104,7 @@ private Request buildPostRequest( | |||
| response = client.newCall(request).execute(); | |||
| responseBody = response.body().string(); | |||
| } catch (final IOException e) { | |||
| throw new EnclaveException("Failed to contact Enclave", e); | |||
| throw new RuntimeException("Failed to contact Enclave", e); | |||
There was a problem hiding this comment.
Not sure about this change. EnclaveException extends IllegalArgumentException which is a little misleading as this is a connection error.
If this is not ok let me know.
There was a problem hiding this comment.
👍 Worse things have/will happen.
iikirilov
force-pushed
the
pan-2928-return-null-private-tx-receipt
branch
from
3bd6997 to
07465e2
Compare
rain-on
reviewed
Sep 10, 2019
...pegasys/pantheon/ethereum/jsonrpc/internal/privacy/methods/eea/EeaGetTransactionReceipt.java
Outdated
Show resolved
Hide resolved
...pegasys/pantheon/ethereum/jsonrpc/internal/privacy/methods/eea/EeaGetTransactionReceipt.java
Show resolved
Hide resolved
…t have transaction
iikirilov
force-pushed
the
pan-2928-return-null-private-tx-receipt
branch
from
fa0fe33 to
0dac15d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
return null instead of error if private transaction does not exists
Fixed Issue(s)
PAN-2928