This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2982] Modifies PrivGetPrivateTransaction to take public tx hash #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-richardson
force-pushed
the
modify-priv-getPrivateTransaction
branch
from
7d8ee97
to
539d4fb
Compare
|
Seems to be stalling while pulling my branch? |
…ichardson/pantheon into modify-priv-getPrivateTransaction
josh-richardson
added a commit
to josh-richardson/pantheon
that referenced
this pull request
Jul 30, 2019
…egaSysEng#1778) * Modifies PrivGetPrivateTransaction to take public tx hash * Fix star imports
MadelineMurray
pushed a commit
that referenced
this pull request
Jul 30, 2019
* [PAN-2943] Renames various eea methods to priv methods, with associated docs (#1736) * Renames various eea methods to priv methods, with associated docs * Restructures packages * Adds priv commandline switch * Refactors eea_getTransactionCount and eea_getPrivateTransaction to priv * Changes package structure and fixes TODO * Remove whitespace * Update docs with new method names * [PAN-2972] Additional integration test for contract creation with privacyGroupId (#1762) * Unit test for send raw transaction with privacy group * Integration test works a bit better now, need to abstract to a separate subclass, fix verifyForParticipants logic bug * Abstracts nodeCanDeployWithPrivacyGroupId to separate acceptance test * Tidies up integration test * Fix whitespace * Fix inspection issues * Restructure private transaction builder * Fix default privateFrom behaviour * Remove enclave public key from parameter (#1777) * [PAN-2982] Modifies PrivGetPrivateTransaction to take public tx hash (#1778) * Modifies PrivGetPrivateTransaction to take public tx hash * Fix star imports
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
eea_sendTransaction returns the public tx hash.
priv_getPrivateTx takes the input field from the object returned by eth_getTransactionByHash as a parameter. So before calling priv_getPrivateTx, the user must call eth_getTransactionByHash specifying the public tx hash as input.
Updating priv_getPrivateTransaction to take public tx hash as parameter means instead of the user performing 2 requests to get the private tx: eea_sendTransaction -> returns public tx hash -> eth_getTransactionByHash -> input value -> priv_getPrivateTx
It would be 1: eea_sendTransaction -> returns public tx hash -> priv_getPrivateTx
Acceptance criteria:
priv_getPrivateTx takes the public tx hash as a parameter and returns the private tx