This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2910] Eea get private transaction fix #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*encode numbers in hex *represent enclave keys in base64
Support for the following combinations *privateFrom and privateFor *privateFrom and privacyGroupId *privacyGroupId without privateFrom - the privateFrom field is populated from the enclave key used in the command line arguments to start up Pantheon.
*the privacy marker transaction payload is required in base64 for orion receive requests
iikirilov
commented
Jul 15, 2019
| + "6c393153476f3dac4b6f32625671442b6e4e6c4e594c35454537793349644f" | ||
| + "6e766966746a69697a706a52742b4854754642733d8a726573747269637465" | ||
| + "64"; | ||
| "0xf8ef800182520894095e7baea6a6c7c4c2dfeb977efac326af552d87a0f" |
There was a problem hiding this comment.
Test vectors have changed here because enclave keys encoded correctly as 32 byte hex rather than 44 byte UTF_8 representation of base64
iikirilov
force-pushed
the
eeaGetPrivateTransaction_fix
branch
from
0cceaa2
to
590f84a
Compare
lucassaldanha
approved these changes
Jul 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The response of the ee_getPrivateTransaction endpoint should return numeric values encoded in hex and enclave public keys encoded in base64. It should also return the private transaction with the privateFrom/privateFor or privateFrom/privacyGroupId combination depending on how the transaction was sent.
This PR also extends to fix the way transactions are sent with support for the following combinations:
This PR also extends from #1667 to handle PMT payload consistently
Fixed Issue(s)
PAN-2910