This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2905] EIP-1706 - Disable SSTORE with gasleft lt call stipend #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pend Add minimum remaining gas check to exceptional halt reasons. Configure it to zero pre-istanbul and 2300 for istanbul.
mbaxter
reviewed
Jul 15, 2019
| @@ -27,8 +27,14 @@ | |||
|
|
|||
| public class SStoreOperation extends AbstractOperation { | |||
|
|
|||
| public SStoreOperation(final GasCalculator gasCalculator) { | |||
| public static final Gas FRONTIER_MINIMUM = Gas.ZERO; | |||
| public static final Gas EIP_1706_MINIMUM = Gas.of(2300); | |||
There was a problem hiding this comment.
If we follow the existing pattern, I think these gas values belong on the GasCalculator?
There was a problem hiding this comment.
see #1704 (comment)
|
|
||
| private final Gas minumumGasRemaining; | ||
|
|
||
| public SStoreOperation(final GasCalculator gasCalculator, final Gas minumumGasRemaining) { |
There was a problem hiding this comment.
(discussion) Since this new minimum gas check is backwards-compatible, should we just always apply it? Rather than having separate minima for frontier vs istanbul?
There was a problem hiding this comment.
It is not backwards compatible. Over 100 reference tests have broken so far in my test run and the build is not done yet.
There was a problem hiding this comment.
169 to be exact. Across a broad set of tests.
mbaxter
approved these changes
Jul 15, 2019
# Conflicts: # ethereum/core/src/main/java/tech/pegasys/pantheon/ethereum/mainnet/MainnetEvmRegistries.java # ethereum/core/src/main/java/tech/pegasys/pantheon/ethereum/mainnet/MainnetProtocolSpecs.java
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Add minimum remaining gas check to exceptional halt reasons. Configure it
to zero pre-istanbul and 2300 for istanbul.