This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2829] Add accountVersion to MessageFrame #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the current contract's version to the message frame.
mbaxter
approved these changes
Jul 12, 2019
| @@ -912,6 +920,11 @@ public Builder contract(final Address contract) { | |||
| return this; | |||
| } | |||
|
|
|||
| public Builder contractAccountVersion(final int contractAccountVersion) { | |||
| this.contractAccountVersion = contractAccountVersion; | |||
There was a problem hiding this comment.
Probably worth asserting the value is >= 0.
…andom negative array index issues. Catch it earlier at a better spot.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Add the current contract's version to the message frame. For a contract
creation transaction the version is the fork default version.
Fixed Issue(s)