This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2897] Return hashrate of 0 when not mining. #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
reviewed
Jul 11, 2019
| return new JsonRpcErrorResponse(req.getId(), JsonRpcError.NO_HASHES_PER_SECOND); | ||
| return hashesPerSecond | ||
| .map(hashes -> new JsonRpcSuccessResponse(req.getId(), Quantity.create(hashes))) | ||
| .orElseGet(() -> new JsonRpcSuccessResponse(req.getId(), Quantity.create(0))); |
There was a problem hiding this comment.
return new JsonRpcSuccessResponse(req.getId(), Quantity.create(hashesPerSecond.orElse(0))?
There was a problem hiding this comment.
yep -- I made it better -- you've helped more -- thanks.
|
You've also accidentally reverted the reference test upgrade. Checkout master, run |
rojotek
force-pushed
the
eth-hashrate-not-mining
branch
from
8536f9a
to
bfdb083
Compare
rojotek
force-pushed
the
eth-hashrate-not-mining
branch
from
bfdb083
to
1f77131
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return Hashrate of 0 when not mining.