Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

PAN-2076 Update PantheonCommand to accept minTransactionGasPriceWei as an integer #1668

Merged
merged 7 commits into from
Jul 11, 2019
Merged

PAN-2076 Update PantheonCommand to accept minTransactionGasPriceWei as an integer #1668

merged 7 commits into from
Jul 11, 2019

Conversation

matkt
Copy link
Contributor

@matkt matkt commented Jul 10, 2019

PR description

Eliminates the need to put quotes in a TOML file for the min-gas-price field. this field is now an integer

Copy link
Contributor

@shemnon shemnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a lower touch solution would be to add an if block for Wei in the TomlConfigFileDefaultProvider -

@matkt
Copy link
Contributor Author

matkt commented Jul 10, 2019

I think a lower touch solution would be to add an if block for Wei in the TomlConfigFileDefaultProvider -

Indeed changing this file is easier and faster. Good comment

@matkt matkt closed this Jul 10, 2019
@matkt matkt reopened this Jul 10, 2019
Copy link
Contributor

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@AbdelStark AbdelStark merged commit f89f922 into PegaSysEng:master Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants