This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Sanity check the generated distribution files before upload #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also sanity check as part of build so we know if the checks start failing prior to the actual release.
joshuafernandes
approved these changes
Jul 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The 1.1.4 release had issues because a conflict between the docker and application gradle plugins resulted in a valid
tar.gzdistribution but azipdistribution containing only theDockerfile.This adds a very primitive sanity check to ensure the
tar.gzandzipdistribution files are suitably large prior to uploading them. The check is also performed as part of a normalbuildto ensure the checks are passing as part of a normal build.