Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

remove the docker gradle plugin, handle building docker with shell now #1644

Merged
merged 3 commits into from
Jul 4, 2019
Merged

remove the docker gradle plugin, handle building docker with shell now #1644

merged 3 commits into from
Jul 4, 2019

Conversation

joshuafernandes
Copy link
Contributor

PR description

Fixed Issue(s)

  • remove the docker gradle plugin, handle building docker with shell now

ajsutton
ajsutton approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just need to make build artefacts go into the build dir.

build.gradle Outdated Show resolved Hide resolved
@joshuafernandes joshuafernandes merged commit 5bfc2d1 into PegaSysEng:master Jul 4, 2019
@joshuafernandes joshuafernandes deleted the fix-docker-plugin branch July 7, 2019 21:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ajsutton ajsutton ajsutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshuafernandes @ajsutton