Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

[PIE-1737] Simplify PantheonCommand run and parse methods. #1626

Merged
merged 4 commits into from
Jul 2, 2019
Merged

[PIE-1737] Simplify PantheonCommand run and parse methods. #1626

merged 4 commits into from
Jul 2, 2019

Conversation

AbdelStark
Copy link
Contributor

PR description

Split parse and run methods into smaller methods to improve readability.

Fixed Issue(s)

@AbdelStark
split parse method
4463fa0 
- handleStandaloneCommand
- addSubCommands
- registerConverters
- handleUnstableOptions
- preparePlugins
- parse
@AbdelStark
Merge remote-tracking branch 'upstream/master' into feature/pie-1737-…
b24408e 
…simplify-pantheon-command
@AbdelStark
split run method
afa0784 
-checkOptions
- configure
- controller
- startPlugins
- startSynchronization
@AbdelStark AbdelStark added the refactoring Related to refactoring of code label Jul 2, 2019
NicolasMassart
NicolasMassart approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Note on the future of this code part: breaking changes in PicoCLI next version (4.0 release still in beta) will require to rework this part entirely. Some changes will be done also on how we handle Docker and then standalone commands.

@AbdelStark AbdelStark merged commit d144a20 into PegaSysEng:master Jul 2, 2019
@AbdelStark AbdelStark deleted the feature/pie-1737-simplify-pantheon-command branch July 2, 2019 08:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicolasMassart NicolasMassart NicolasMassart approved these changes

Assignees
No one assigned
Labels
refactoring Related to refactoring of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbdelStark @NicolasMassart