This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PIE-1723] Cache TransactionValidationParams instead of creating new object for each call #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…object for each call - cache static methods return values in constant fields - don't use `Builder` internally - add tests
lucassaldanha
approved these changes
Jun 28, 2019
AbdelStark
deleted the
feature/pie-1723-cache-transaction-validation-params
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
TransactionValidationParamsstatic methods return a new instance ofTransactionValidationParamseach time they are called.For exampleprocessingBlock()is invoked for each transaction in every block. To avoid creating a lot of instances this PR caches the different possible variants(currently 5) in memory. Once created they are not mutable so there is no risk of race conditionBuilderinternallyFixed Issue(s)