This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PIE-1710] Expose a CLI option to configure the life time of transaction messages. #1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion messages. - add a cli option `--tx-pool-message-keep-alive-seconds`
mbaxter
approved these changes
Jun 26, 2019
ajsutton
reviewed
Jun 26, 2019
| paramLabel = MANDATORY_INTEGER_FORMAT_HELP, | ||
| description = "Keep alive of transactions in seconds (default: ${DEFAULT-VALUE})", | ||
| arity = "1") | ||
| private final Integer txMessageKeepAliveSeconds = TransactionPool.DEFAULT_TX_MSG_KEEP_ALIVE; |
There was a problem hiding this comment.
I don't think this should be a visible option - it's potentially very misleading for users and ideally wouldn't ever kick in since we should keep up with transaction messages. I'd say it should just be a -X option.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
We want to make configurable the life time of transactions. This life time is used to drop incoming transactions from the network if they are too old.
--tx-pool-keep-alive-secondsFixed Issue(s)
#PIE-1710