Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

[PIE-1709] Implement Prometheus metric counter for skipped expired transaction messages. #1609

Conversation

AbdelStark
Copy link
Contributor

PR description

Follow up PR of #1604
We want to provide Prometheus metrics when the TransactionsMessageProcessor skips some expired messages.

  • a prometheus counter is created for skipped messages
  • the counter is updated when a message is skipped.
  • a log is provided every time a step is hit (default is 1000).

Fixed Issue(s)

#PIE-1709

@AbdelStark AbdelStark added enhancement New feature or request performance Related to performance labels Jun 26, 2019
@NicolasMassart
Copy link
Contributor

Why counting in Pantheon and not just sending an event on the metrics API (received usually by Prometheus in our case) and let Prometheus count and build the aggregated data? It would remove the need to maintain a counter in Pantheon.

@AbdelStark
Copy link
Contributor Author

Why counting in Pantheon and not just sending an event on the metrics API (received usually by Prometheus in our case) and let Prometheus count and build the aggregated data? It would remove the need to maintain a counter in Pantheon.

The interface actually use Prometheus API.

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change and clarifying the code, LGTM now

@AbdelStark AbdelStark merged commit f52163e into PegaSysEng:master Jun 26, 2019
@AbdelStark AbdelStark deleted the feature/pie-1709-metrics-skipped-tx-messages branch June 26, 2019 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request performance Related to performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants