This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Reject transactions with gas price below the configured minimum #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Reject transactions with a gas price below the configured minimum gas price before full validation or adding to the pending transaction pool. The check for minimum gas price is much cheaper than our other validation and transactions below that limit won't be mined so are easy targets for disposal.
Remove the
setMinTransactionGasPricefrom MiningCoordinator. We never implemented the JSON-RPC method to adjust the min transaction gas price at runtime and the minimum price is now need in more than just theMiningCoordinator. If/when we later add those RPC methods, we'll need to come up with a different design so the new value can be shared.