This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-1952] - Remove ignored pending transaction event publish acceptance test #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The acceptance test for "verifying that events get published when transactions are removed because of chain reorganisation" is being deleted because the way test case is simulating chain reorganisation is resulting in an inconsistent number of events fired. There are already unit test cases and other acceptance cases around validating pending transactions events hence this test case can be safely removed. Signed-off-by: Usman Saleem <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
The acceptance test for "verifying that events get published when
transactions are removed because of chain reorganisation" is being
deleted because the way test case is simulating chain reorganisation
is resulting in an inconsistent number of events fired.
There are already unit test cases and other acceptance cases around
validating pending transactions events with sufficient coverage hence this test case can be
safely removed.