This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2009] - Fix cluster clean start after stop in Acceptance tests #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Clear bootnodes on cluster start
- Pass bootnodes list only to non-boot nodes in cluster startNode
- Do not shutdown pantheonNodeRunner from stop method
- Call stop from cluster close method
- Fix getBootnodes to setBootnodes in NodeConfiguration
- Init outputProcessorExecutor in startNode in ProcessPantheonNodeRunner
(allows clean start after a close or shutdown)
- Init PluginContextImpl once per node in ThreadPantheonNodeRunner
(allows clean start after a close or shutdown)
- Add new acceptance test for a cluster to clean start after stop
- Allow PantheonPluginContextImpl to clean start plugins after stop
Signed-off-by: Usman Saleem <[email protected]>
ajsutton
reviewed
Jun 11, 2019
...src/test/java/tech/pegasys/pantheon/tests/acceptance/dsl/node/ProcessPantheonNodeRunner.java
Outdated
Show resolved
Hide resolved
.../src/test/java/tech/pegasys/pantheon/tests/acceptance/dsl/node/ThreadPantheonNodeRunner.java
Show resolved
Hide resolved
.../java/tech/pegasys/pantheon/tests/acceptance/pubsub/NewPendingTransactionAcceptanceTest.java
Outdated
Show resolved
Hide resolved
pantheon/src/main/java/tech/pegasys/pantheon/services/PantheonPluginContextImpl.java
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Allow a cluster to be restarted after a stop.
(allows clean start after a close)